[SYCL][NFC] Drop leftover host device symbols #20172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host device had been removed a while ago, but we still exported some `__spirv` symbols which were even referenced on some code paths. This commit prepares for their removal in the next ABI-breaking window
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sycl/include/sycl/detail/spirv.hpp
Outdated
| __nvvm_bar_warp_sync(detail::ExtractMask(detail::GetMask(g))[0]); | ||
| #else | ||
| #elif defined(__SYCL_DEVICE_ONLY__) | ||
| (void)g; |
There was a problem hiding this comment.
Make it [[maybe_unused]] too, otherwise there will be a warning on the host.
There was a problem hiding this comment.
Addressed in 3d66a50
sycl/source/detail/platform_util.hpp
Outdated
|
|
||
| static uint64_t getMemCacheSize(); | ||
|
|
||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES |
There was a problem hiding this comment.
Where is it used? Can we just drop unconditionally?
There was a problem hiding this comment.
It is used in spirv_ops.cpp. but since PlatformUtil isn't exported on its own we should indeed be able to remove it straight away
There was a problem hiding this comment.
Removed in 3d66a50
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
approved these changes
Sep 23, 2025
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
deleted the
private/asachkov/drop-__spirv_-funcs-from-the-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host device had been removed a while ago, but we still exported some
__spirvsymbols which were even referenced on some code paths.This commit prepares for their removal in the next ABI-breaking window